Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing header in ResourceUsage.h #143

Closed
wants to merge 1 commit into from
Closed

Conversation

SF-N
Copy link

@SF-N SF-N commented Oct 18, 2024

ResourceUsage.h used size_t, but did not include the stddef header. This lead to some compilation errors in atlas4py.

@FussyDuck
Copy link

FussyDuck commented Oct 18, 2024

CLA assistant check
All committers have signed the CLA.

@pmaciel
Copy link
Member

pmaciel commented Oct 18, 2024

Note that the #include above takes care of this

@SF-N
Copy link
Author

SF-N commented Oct 18, 2024

It wasn't working with clang-1500.3.9.4 and when looking at https://en.cppreference.com/w/c/types/size_t it seems like the includes above don't take care of this.

@wdeconinck
Copy link
Member

Something strange, because you should not use the C compiler but rather the C++ compiler, and there size_t should be defined in many possible headers including cstddef as is already included.
"https://en.cppreference.com/w/cpp/types/size_t"

Please could you provide us the platform information, full compiler invocation and error message?

@SF-N
Copy link
Author

SF-N commented Oct 29, 2024

@wdeconinck and I just figured it out: it was due to an older eckit-version used in atlas4py which didn't include that header.

@SF-N SF-N closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants